Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of GraphUrl with url::Url in graph-codegen #435

Open
sreeise opened this issue May 10, 2023 · 0 comments
Open

Replace use of GraphUrl with url::Url in graph-codegen #435

sreeise opened this issue May 10, 2023 · 0 comments
Labels

Comments

@sreeise
Copy link
Owner

sreeise commented May 10, 2023

The GraphUrl in graph-http is no longer used in any of the main client code, not 100% sure though. Either way the use of GraphUrl in graph-codegen, and if its used anywhere else, needs to be replaced with url::Url which is a crate in the Rust ecosystem and used in this crate almost everywhere. Its what GraphUrl uses internally.

If there is specific funtionallity of GraphUrl that is needed for codegen, and that is not already part of url::Url, we should consider creating an ext trait in graph-codegen and an impl of that trait for url::Url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant