Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Webview panic without gtk::init call #461

Open
sreeise opened this issue Feb 1, 2024 · 0 comments
Open

Possible Webview panic without gtk::init call #461

sreeise opened this issue Feb 1, 2024 · 0 comments
Assignees
Labels
interactive-auth feature interactive-auth - Microsoft sign in using WebView on platforms that support it
Milestone

Comments

@sreeise
Copy link
Owner

sreeise commented Feb 1, 2024

According to Wry docs the Webview will panic on Linux if gtk::init is not called. See WebViewBuilder::new docs. However, the linked Platform Considerations from Wry seem to state that this only happens when the windowing library doesn’t support gtk.

Current windowing library that we use is Tao. This ticket is to verify whether or not gtk::init needs ot be called and if so add the calls to the relevant places. Check if Tao already does this. If not, then we will need to add a call to gtk::init before the event loop and during each event loop call the following as shown in the Platform Considerations:

#[cfg(target_os = "linux")]
while gtk::events_pending() {
  gtk::main_iteration_do(false);
}
@sreeise sreeise added the interactive-auth feature interactive-auth - Microsoft sign in using WebView on platforms that support it label Feb 1, 2024
@sreeise sreeise added this to the 2.0.0 milestone Feb 1, 2024
@sreeise sreeise self-assigned this Feb 1, 2024
@sreeise sreeise changed the title Webview panic without gtk::init call - 2.0.0 Release Goal Possible Webview panic without gtk::init call - 2.0.0 Release Goal Feb 1, 2024
@sreeise sreeise moved this to Todo in OAuth Standardization Feb 1, 2024
@sreeise sreeise changed the title Possible Webview panic without gtk::init call - 2.0.0 Release Goal Possible Webview panic without gtk::init call - 2.1.0 Release Goal May 27, 2024
@sreeise sreeise modified the milestones: 2.0.0, 2.1.0, 2.2.0 May 27, 2024
@sreeise sreeise changed the title Possible Webview panic without gtk::init call - 2.1.0 Release Goal Possible Webview panic without gtk::init call May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interactive-auth feature interactive-auth - Microsoft sign in using WebView on platforms that support it
Projects
Development

No branches or pull requests

1 participant