-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
high_volubility.py: chunk sizes #125
Comments
@alecristia - you will know best how this is supposed to work? |
No, sorry - and the second one looks like a bug, so I'm tagging Marvin |
Yep this functions needs the previous list of onsets. Therefore, the first one must be computed differently, with the select_onsets function
With the following parameters : a) a wav file of 3000 seconds
745 became 690, 145 became 90, etc ... :
[600.0, 0.0] 690 became 600, 90 became 0, etc ... Going back to first list of onsets ([145.0, 745.0, 1345.0, 1945.0, 2545.0]), we see that we chose :
The bugs you are describing might have been fixed by this commit |
It is possible to modify the size of the chunks for the first, second and third extraction steps with the --chunk_sizes argument, however the
new_onset_*_minutes
function used to compute the onsets to extract those chunks only exists for 2 (second extraction step) and 5 (third extraction step) minutes:new_onsets_two_minutes
the new onset seems to be later than the given onset, meaning the extracted chunk which was supposed to be centered on the smaller chunks starts in the middle of the smaller chunk, is that on purpose?new_onsets_five_minutes
the new onset is 2 minutes before the current onset, no matter the length asked for (it could be that the --chunk_sizes argument was [10.0, 120.0, 120.0] and then none of the chunks would contain the data based on which they were ranked)I don't know which behavior was expected, but the second one at least can be conflicting with what the script is supposed to output.
The text was updated successfully, but these errors were encountered: