Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Drive Week 7 #1

Open
elevenpassin opened this issue Apr 23, 2019 · 1 comment
Open

Documentation Drive Week 7 #1

elevenpassin opened this issue Apr 23, 2019 · 1 comment

Comments

@elevenpassin
Copy link

Here are a few problems that I would like to draw your attention to:

  • No description, you can't really tell what the package is being used for at a first glance. (Add a small sentence briefly explaining what problem the package attempts to solve)
  • Exports are not documented (name, version, manifest & init properties)
  • Explain what manifest & init exports are for and what they do (in case of functions)
  • defaultIds in the options property of the method ssb-server.suggest.profile(opts, cb) has a default value of an empty array. This is not specified in the documentation
  • It's not clear what is happening when you register the plugin with the server.
@KyleMaas
Copy link

I would think this is pretty good now - I was able to integrate ssb-suggest into ssb-browser-core without prior knowledge of what it was or how it was supposed to be used. Can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants