Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR1 | Validation 6 | comments and compliance mismatch #288

Closed
MathesonSho opened this issue Dec 3, 2024 · 2 comments · Fixed by #300
Closed

GR1 | Validation 6 | comments and compliance mismatch #288

MathesonSho opened this issue Dec 3, 2024 · 2 comments · Fixed by #300
Assignees
Labels
bug Something isn't working Comment Update compliance messages Iteration #1 Before V2.0 go-live

Comments

@MathesonSho
Copy link
Contributor

Describe the bug #1
When a client has not uploaded the required file the comment does not explain what the client needs to do. It says the item name instead of the document name that it should be looking for.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any tenant
  2. Remove “UserAccountsPrivilegedAndRegularUPN.csv ”
  3. Run main runboook
  4. See error in workbook

Expected behavior
Non-compliant and explains that you need to upload a file with the name “UserAccountsPrivilegedAndRegularUPN.csv ”

Screenshots
image
Software versions used:

  • Azure CaC v2.1.2

Describe the bug #2
When a client has uploaded the required file but only included the highly privileged UPNs the comment does not explain that any fields are missing.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any tenant
  2. Add the“UserAccountsPrivilegedAndRegularUPN.csv ” while only filling in the left most column with GA UPNs
  3. Run main runboook
  4. See error in workbook

Expected behavior
Non-compliant and explains that there are no UPNs for the non-privileged accounts.

Software versions used:

  • Azure CaC v2.1.2

Describe the bug #3
When a client has uploaded the required file but only included the regular UPNs in the left most column the comment does not explain that any fields are missing.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any tenant
  2. Add the“UserAccountsPrivilegedAndRegularUPN.csv ” while only filling in the left most column with regular account UPNs
  3. Run main runboook
  4. See error in workbook

Expected behavior
Result focused on the fact that there may be an account listed without GC privileges in the incorrect column which is good. However, it is missing the fact that there isn't a second column for the matching privileged and non-privileged UPNS.

Suggest updating the logic to ensure this is a non-compliant result

Software versions used:

  • Azure CaC v2.1.2

Additional context
Use cases sent to you via email.

@MathesonSho MathesonSho added the bug Something isn't working label Dec 3, 2024
@dutt0
Copy link
Contributor

dutt0 commented Dec 4, 2024

@MathesonSho The csv file format below:
image

@dutt0 dutt0 self-assigned this Dec 4, 2024
@dutt0 dutt0 added PriorityForAssignees -Next Iteration #1 Before V2.0 go-live Comment Update compliance messages labels Dec 4, 2024
@dutt0
Copy link
Contributor

dutt0 commented Dec 9, 2024

Bug #1 fix is in progress.
Other reported bugs here need re-testing with the csv format above @MathesonSho. We might want to create a separate ticket if those exists

@dutt0 dutt0 linked a pull request Dec 9, 2024 that will close this issue
6 tasks
@dutt0 dutt0 closed this as completed in #300 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Comment Update compliance messages Iteration #1 Before V2.0 go-live
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants