Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MantaCommunicationError should disconnect #34

Open
ssfrr opened this issue Nov 3, 2014 · 0 comments
Open

MantaCommunicationError should disconnect #34

ssfrr opened this issue Nov 3, 2014 · 0 comments

Comments

@ssfrr
Copy link
Owner

ssfrr commented Nov 3, 2014

Generally the only reason we get a read/write error from HIDAPI is because the Manta is disconnected. I think the current behavior is to treat the error as nonfatal and leave it up to the application to disconnect and then go back into manta discovery mode. This seems unnecessarily complex and isn't necessarily obvious. I think a better option is to handle all the disconnect logic before handing the exception up to the application. The app is then free to reconnect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant