Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use specific action versions #24

Closed

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Sep 19, 2022

GitHub Actions unfortunately runs the latest version of the actions which fits the uses directive version. So right now actions/checkout@v3 is equivalent to actions/[email protected], but this can change at any time. To avoid workflows suddenly failing in case a new minor/patch version of an action, this PR uses the most specific version number available for the checkout action.

Avoids quietly using whichever version is the latest starting with the
specified version number, which could break at any time.
@m-mohr
Copy link
Contributor

m-mohr commented Sep 19, 2022

So if a security-related bugfix would be issued it would not be included. I think I'd prefer the latest non-breaking version that is safe and accept a broken dependency in rare cases, especially as the extensions are not always actively maintained and the updates of the dependencies would lead to a lot of friction. But maybe that's just me...

@l0b0
Copy link
Contributor Author

l0b0 commented Sep 19, 2022

The security issue is a bit of six of one and half dozen of the other. Running a specific version gives you a little time in case someone introduces a new security hole in a release and it's discovered before merging the Dependabot PR. That said, I'm not sure what kind of damage a security-related bug could even do in one of this project's included actions.

@l0b0
Copy link
Contributor Author

l0b0 commented Mar 13, 2023

Ping?

1 similar comment
@l0b0
Copy link
Contributor Author

l0b0 commented May 16, 2023

Ping?

@l0b0
Copy link
Contributor Author

l0b0 commented Sep 28, 2023

I don't work with STAC anymore, so I've unsubbed from this. Please @ me if you would like some further feedback.

@m-mohr
Copy link
Contributor

m-mohr commented Oct 2, 2023

Solved by #26

@m-mohr m-mohr closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants