-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable use of custom Slurm builds #163
Draft
sjpb
wants to merge
49
commits into
master
Choose a base branch
from
feat/no-ohpc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2024
sd109
previously approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sjpb
force-pushed
the
feat/no-ohpc
branch
12 times, most recently
from
March 19, 2024 15:34
a5709a6
to
34606b0
Compare
sjpb
force-pushed
the
feat/no-ohpc
branch
2 times, most recently
from
July 24, 2024 14:44
4200fa3
to
9f8e765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an
install-generic.yml
task book which can use existing Slurm binaries/libraries rather than installing OpenHPC packages.Note that the
./configure
command for the Slurm build used with this must:--sysconfdir
to match the directory ofopenhpc_slurm_conf_path
(default:/etc/slurm/slurm.conf
)--prefix
to match the directory the slurm daemon binaries are deployed at (seeopenhpc_sbin_dir
). This is becausePluginDir
defaults to being based on the build prefix. Although it can be overriden inslurm.conf
, theslurmd
s do not appear to get this parameter when running configless, so they won't start saying the (default) plugin dir doesn't existAdds
openhpc_config_files
to allow arbitrary Slurm configuration files to be templated.Adds
openhpc_slurmd_spool_dir
to allow SlurmdSpoolDir parameter to be modified.TODO: needs to be updated to support RL9, see cgroups change in #164, this should be done by default.