From 3a93ab5cc7053908eae763189e9550bdd442aa50 Mon Sep 17 00:00:00 2001 From: Simon Stier Date: Wed, 4 Dec 2024 07:49:47 +0100 Subject: [PATCH 1/2] Update codeowners --- CODEOWNERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index eac0c9f..899ef41 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,4 +1,4 @@ -* patrick.koss@mail.schwarz +* patrick.koss@stackit.cloud * marius.galm@mail.schwarz -* simon.stier@mail.schwarz -* christopher.paul@mail.schwarz +* simon.stier@stackit.cloud +* florian.sandel@stackit.cloud From bef6454edbb75aa08ecca6c0c45794ba911f54c9 Mon Sep 17 00:00:00 2001 From: Simon Stier Date: Thu, 5 Dec 2024 08:43:30 +0100 Subject: [PATCH 2/2] Fix chart appVersion --- .github/workflows/release.yaml | 2 +- README.md | 2 +- deploy/stackit/Chart.yaml | 6 +++--- deploy/stackit/templates/deployment.yaml | 2 +- deploy/stackit/values.yaml | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 11ac2fc..7639081 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -3,7 +3,7 @@ name: Release on: push: tags: - - "*" + - "v*" permissions: read-all diff --git a/README.md b/README.md index 8b4a263..eb8d257 100644 --- a/README.md +++ b/README.md @@ -234,5 +234,5 @@ For those interested in the Helm chart creation mechanics, the process was facil helm package deploy/stackit ``` -To release a new version of the Helm chart, one must meticulously update the version delineation in the +To release a new version of the Helm chart, one must meticulously update the appVersion and (chart)version delineation in the [Chart.yaml](./deploy/stackit/Chart.yaml). Post this modification, initiate a new release to encompass these changes. diff --git a/deploy/stackit/Chart.yaml b/deploy/stackit/Chart.yaml index 2e42a01..26202a0 100644 --- a/deploy/stackit/Chart.yaml +++ b/deploy/stackit/Chart.yaml @@ -1,5 +1,5 @@ apiVersion: v1 -appVersion: "1.0" -description: A Helm chart for Kubernetes +appVersion: "v0.3.1" +description: A Helm chart for stackitcloud/stackit-cert-manager-webhook name: stackit-cert-manager-webhook -version: 0.3.2 +version: 0.3.3 diff --git a/deploy/stackit/templates/deployment.yaml b/deploy/stackit/templates/deployment.yaml index 0d41713..2634610 100644 --- a/deploy/stackit/templates/deployment.yaml +++ b/deploy/stackit/templates/deployment.yaml @@ -23,7 +23,7 @@ spec: serviceAccountName: {{ include "stackit-cert-manager-webhook.fullname" . }} containers: - name: {{ .Chart.Name }} - image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" + image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" imagePullPolicy: {{ .Values.image.pullPolicy }} args: - --tls-cert-file=/tls/tls.crt diff --git a/deploy/stackit/values.yaml b/deploy/stackit/values.yaml index 7229f65..edaee5c 100644 --- a/deploy/stackit/values.yaml +++ b/deploy/stackit/values.yaml @@ -23,8 +23,8 @@ certManager: image: # -- repository of the image. repository: ghcr.io/stackitcloud/stackit-cert-manager-webhook - # -- tag of the image. - tag: v0.3.1 + # Overrides the image tag whose default is {{ .Chart.AppVersion }} + tag: "" # -- pull policy of the image. pullPolicy: IfNotPresent