Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Always derive aggregate keys from the signer set #511

Closed
1 task
djordon opened this issue Sep 12, 2024 · 2 comments
Closed
1 task

[Feature]: Always derive aggregate keys from the signer set #511

djordon opened this issue Sep 12, 2024 · 2 comments
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Sep 12, 2024

Feature - Always derive aggregate keys the signer set

1. Description

Some places in the code base derive the aggregate key from the signer set, while other places just accept that the aggregate key matches the signer set. I believe we currently pass in the right thing, but better to make such a mistake impossible.

1.1 Context & Purpose

There are places in the code where it appears that we should do additional validation, but it would be best to ensure that this internal validation always happens so that there is no chance for programmer error.

2. Technical Details:

2.1 Acceptance Criteria:

  • Make sure signer set is always mapped to the associated aggregate key.

3. Related Issues and Pull Requests (optional):

@djordon
Copy link
Contributor Author

djordon commented Oct 4, 2024

Oh, we cannot do this until #614 gets done.

@djordon
Copy link
Contributor Author

djordon commented Dec 12, 2024

Like in #614 (comment), I no longer think that we should do this.

@djordon djordon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in sBTC Dec 12, 2024
@djordon djordon moved this from Done to Needs Triage in sBTC Dec 12, 2024
@djordon djordon moved this from Needs Triage to Done in sBTC Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

No branches or pull requests

1 participant