From e6097d93137330636e03e324efb385849dfa5b1c Mon Sep 17 00:00:00 2001 From: MuhammadUmer44 Date: Fri, 1 Nov 2024 10:10:40 +0500 Subject: [PATCH 1/3] fix(filter): filter buttons sticky --- .../App/SideBar/FilterSearch/index.tsx | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/components/App/SideBar/FilterSearch/index.tsx b/src/components/App/SideBar/FilterSearch/index.tsx index f7dc72322..b81677080 100644 --- a/src/components/App/SideBar/FilterSearch/index.tsx +++ b/src/components/App/SideBar/FilterSearch/index.tsx @@ -114,8 +114,8 @@ export const FilterSearch = ({ anchorEl, setAnchorEl, onClose }: Props) => { - + Date: Fri, 1 Nov 2024 17:24:57 +0500 Subject: [PATCH 2/3] fix(search-filter): chnage button name --- src/components/App/SideBar/FilterSearch/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/App/SideBar/FilterSearch/index.tsx b/src/components/App/SideBar/FilterSearch/index.tsx index b81677080..679d96bb0 100644 --- a/src/components/App/SideBar/FilterSearch/index.tsx +++ b/src/components/App/SideBar/FilterSearch/index.tsx @@ -130,7 +130,7 @@ export const FilterSearch = ({ anchorEl, setAnchorEl, onClose }: Props) => { Clear - Show Results + Apply From 27b4da6ffc36e322d294188d9e56f34d0a4870be Mon Sep 17 00:00:00 2001 From: MuhammadUmer44 Date: Fri, 1 Nov 2024 17:30:38 +0500 Subject: [PATCH 3/3] fix(test): unit test --- src/components/App/SideBar/FilterSearch/__tests__/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/App/SideBar/FilterSearch/__tests__/index.tsx b/src/components/App/SideBar/FilterSearch/__tests__/index.tsx index 31d3fdd3f..d6b0046d4 100644 --- a/src/components/App/SideBar/FilterSearch/__tests__/index.tsx +++ b/src/components/App/SideBar/FilterSearch/__tests__/index.tsx @@ -91,14 +91,14 @@ describe('FilterSearch Component', () => { expect(type1Pill).toHaveStyle(`color: ${colors.black}`) }) - it('should apply filters when "Show Results" is clicked', async () => { + it('should apply filters when "Apply" is clicked', async () => { renderComponent() const type1Pill = screen.getByText('Type1') fireEvent.click(type1Pill) - const showResultsButton = screen.getByText('Show Results') + const showResultsButton = screen.getByText('Apply') fireEvent.click(showResultsButton)