Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend [Integration Test] bounty.go handlers BountyBudgetWithdraw #1602

Closed
2 tasks
elraphty opened this issue Mar 8, 2024 · 6 comments · Fixed by #1604
Closed
2 tasks

Backend [Integration Test] bounty.go handlers BountyBudgetWithdraw #1602

elraphty opened this issue Mar 8, 2024 · 6 comments · Fixed by #1604
Labels
backend bounties go Pull requests that update Go code testing
Milestone

Comments

@elraphty
Copy link
Contributor

elraphty commented Mar 8, 2024

Context

We are trying to increase the test coverage for our Golang backend.

File to to test

handlers/bounty.go

Design

Write tests for the bounty handlers, the test should:

  • Should test that the BountyBudgetWithdraw handler gets locked by go mutex when it is called i.e. the handler has to be fully executed before it processes another request.
  • Should test that an Organization's Budget Total Amount is accurate after three (3) successful Budget Withdrawal Requests

Bounty Handlers To Test

BountyBudgetWithdraw

Add tests to bounty_test.go

Acceptance Criteria

  • I have rebased and tested locally before submitting my PR
  • I can submit a PR within 2 days of taking the bounty

References

Here is an example backend test

@elraphty elraphty added backend bounties go Pull requests that update Go code testing labels Mar 8, 2024
@elraphty elraphty added this to the UCI Tests milestone Mar 8, 2024
@MirzaHanan
Copy link
Contributor

Hi @ecurrencyhodler, @elraphty
Please assign me?

@elraphty
Copy link
Contributor Author

elraphty commented Mar 8, 2024

Hi @ecurrencyhodler, @elraphty Please assign me?

Okay.

@MirzaHanan
Copy link
Contributor

Hi @ecurrencyhodler, @elraphty Please assign me?

Okay.

Thanks Bro!

@elraphty
Copy link
Contributor Author

elraphty commented Mar 8, 2024

Hi @ecurrencyhodler, @elraphty Please assign me?

Okay.

Thanks Bro!

What's your Sphinx Chat username?

@MirzaHanan
Copy link
Contributor

Hi @ecurrencyhodler, @elraphty Please assign me?

Okay.

Thanks Bro!

What's your Sphinx Chat username?

Mirza Hanan

@elraphty
Copy link
Contributor Author

elraphty commented Mar 8, 2024

Hi @ecurrencyhodler, @elraphty Please assign me?

Okay.

Thanks Bro!

What's your Sphinx Chat username?

Mirza Hanan

Assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bounties go Pull requests that update Go code testing
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants