Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization Balance Layout #1611

Closed
Antanasijevic opened this issue Apr 12, 2024 · 14 comments
Closed

Organization Balance Layout #1611

Antanasijevic opened this issue Apr 12, 2024 · 14 comments
Assignees
Labels

Comments

@Antanasijevic
Copy link

Antanasijevic commented Apr 12, 2024

@fvalentiner Here is a version for new balance layout.

Balance is split into 4 categories: Current Balance, Completed, Assigned, Opened
Click on each opens page with bounties with selected status.
Categories with insufficient funds have red border and alert icon that expands to label on hover.
For restricted user, who does not have access to balance information, i think we can keep old layout.
Only opened question i have is does "Current balance" opens a new page or just shows the information?

Balance.2.mp4

Figma project
https://www.figma.com/file/1aL3lgG5Rpkti4b0j42fwf/Bounties---FINAL-DESIGNS?type=design&node-id=11657%3A7512&mode=design&t=06hqbCL7ZwcyhA4C-1

Balance components
https://www.figma.com/file/1aL3lgG5Rpkti4b0j42fwf/Bounties---FINAL-DESIGNS?type=design&node-id=11674%3A7721&mode=design&t=06hqbCL7ZwcyhA4C-1

@fvalentiner
Copy link
Contributor

@elraphty here is the final design for the budget section on Workspaces

@fvalentiner
Copy link
Contributor

Some comments from @pitoi :

  • The colors of the boxes and the buttons should not be the same
  • The user doesn't really know how much funds he needs to cover the committed amounts

@tomsmith8
Copy link

tomsmith8 commented Apr 18, 2024

image
  • shows 0 completed which is incorrect for secondbrain
  • each link out button should link out to the workspace view with the correct filter
    • Currently, it links out the general bounties page with filter
  • add comma for USD amount e.g 29,306.60 (current is 29306.60)
  • Current balance -> deposit and withdraw are on the opposite side of the page, if i want to complete an action for current balance (e.g balance is low, I need to add funds), it feels too disconnected
    • Deposit/withdraw could be part of current balance
    • Maybe separate Current Balance versus completed/assigned/open

@elraphty
Copy link
Contributor

image * shows 0 `completed` which is incorrect for secondbrain * each link out button should link out to the workspace view with the correct filter
  • Currently, it links out the general bounties page with filter

  • add comma for USD amount e.g 29,306.60 (current is 29306.60)

  • Current balance -> deposit and withdraw are on the opposite side of the page, if i want to complete an action for current balance (e.g balance is low, I need to add funds), it feels too disconnected

    • Deposit/withdraw could be part of current balance
    • Maybe separate Current Balance versus completed/assigned/open

Thanks for the feedback @tomsmith8, yeah the the completed should be 0, the completed is a new feature we added for bounties that have been completed and code merged but they have not been paid, to activate this on the bounty modal the complete bounty button has to be clicked.

@tomsmith8
Copy link

Very small thing I just spotted (spacing required for new boxes):
Screenshot 2024-04-18 at 14 42 01

@tomsmith8
Copy link

I tested pressing the complete button on one bounty but still shows 0 for me FYI

@elraphty
Copy link
Contributor

I tested pressing the complete button on one bounty but still shows 0 for me FYI

Okay, I will look into these

@elraphty
Copy link
Contributor

I tested pressing the complete button on one bounty but still shows 0 for me FYI

@tomsmith8 I tested the completed feature on Production it seems to be working fine
TEST IMAGE

@Edvardoh
Copy link

Agree with Tom's suggestions - only thing to add is the Assigned and Open amounts seem to be giving me the total overall, not just for the Stakwork Workspace, we definitely don't have that much assigned/open:
Screenshot 2024-04-18 at 9 56 49 AM

@fvalentiner
Copy link
Contributor

@elraphty @Edvardoh also mentioned that when he clicks on any of the links. It takes him to a list only filtered by status and not by workspace as well. So it is showing bounties that de not correspond to the worspace

@Antanasijevic
Copy link
Author

@fvalentiner @pitoi Here is an alternative option.

  • Each box show amount missing
  • While depositing, field can be prepopulated with the amount missing for each status. For example, if user clicks "Deposit" on completed bounties, "Complete" option will be selected, but user will be able to check other statuses too.
    What do you think?
Balance.v3.mp4

@Antanasijevic
Copy link
Author

Antanasijevic commented Apr 22, 2024

@fvalentiner Here is another, simplified solution that i believe would work better. Let's discuss few options.

Balance.v4.mp4

@Antanasijevic
Copy link
Author

@fvalentiner Here is updated video with Deposit modal.

Balance.v5.mp4

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Bounties Platform Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

6 participants
@Edvardoh @Antanasijevic @elraphty @fvalentiner @tomsmith8 and others