Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Ticket Versioning incorrect on ticket builder flow #2195

Closed
humansinstitute opened this issue Dec 16, 2024 · 3 comments · Fixed by #2206
Closed

[Bug] Ticket Versioning incorrect on ticket builder flow #2195

humansinstitute opened this issue Dec 16, 2024 · 3 comments · Fixed by #2206
Assignees
Labels
bounties bug Something isn't working

Comments

@humansinstitute
Copy link
Contributor

When running a ticket builder workflow the ticket updates i.e. in the DB a new description is entered but the same vrsion number is retained and the websocket message doesn't cause a refresh on the page.

  • The bounties/tickets/review endpoint will need updating to account for the new logic with the groups to correctly call the new update method (already used in the front end) and to account for ticket group logic.
  • The websocket response will also need adjusting for ticketgroup logic to retain autorefresh of the component.
@humansinstitute
Copy link
Contributor Author

@MahtabBukhari can you review in line with the versioning updates to Update ticket button?

@MahtabBukhari
Copy link
Contributor

MahtabBukhari commented Dec 16, 2024

@humansinstitute sure assign me

@humansinstitute
Copy link
Contributor Author

Example response from Stakwork:

{
      "value": {
        "featureUUID": "cslqkjknukuelmhhm88g",
        "phaseUUID": "ct02ntsnukuc8v88jhog",
        "ticketUUID": "922b7fd7-5d1b-4f5b-9fa0-d51013eded1e",
        "ticketDescription": "# Ticket Name: Implement Version 3 Update\n\n## Context\n- This ticket is for the implementation of version 3 of our software product.\n- The update is necessary to enhance features, address known issues, and improve user experience.\n- This version aims to integrate recent user feedback and align with the new strategic goals of our company.\n- The update is crucial for maintaining our competitive edge and ensuring customer satisfaction.\n\n## Task\n1. Review the existing codebase to understand current functionalities and limitations.\n2. Implement the new features and improvements outlined in the version 3 specification document.\n3. Conduct unit testing to ensure all new functionalities work as intended.\n4. Collaborate with the QA team for comprehensive testing.\n5. Document any changes made to the codebase and update user manuals if necessary.\n\n## Outcome\n- A fully functional version 3 of the product that includes all specified enhancements and bug fixes.\n- Improved user satisfaction and feedback scores.\n- The updated software should be ready for deployment and meet all outlined strategic objectives.\n\n## Design\n- Review the draft provided for any specific variables or function names to be used.\n- Ensure the user interface is updated to reflect any new features or changes.\n- Update the application logic where necessary to accommodate new functionalities.\n- Ensure backward compatibility with existing user data.\n- <Question> Are there any specific endpoints or external services that will be impacted by this update?\n\n## Acceptance Criteria\n- [ ] All new features are implemented as per the version 3 specification document.\n- [ ] Existing features continue to function without any regressions.\n- [ ] Unit tests cover at least 90% of the new code.\n- [ ] Comprehensive user and QA testing is completed with no critical issues outstanding.\n- [ ] All relevant documentation is updated to reflect changes.\n- [ ] The software is backward compatible with version 2 user data.\n- [ ] The update aligns with the company's strategic goals.\n- [ ] User feedback mechanisms are in place to collect post-update feedback.\n- [ ] Deployment plan is documented and ready.\n- [ ] <Question> Include any additional specific criteria or requirements for this update?"
      },
      "requestUUID": "1111-2222-3333-4444",
      "sourceWebsocket": "NSIXQX6E5XMD7AKPRTQCB2Y3MI5KW7JWIZ6B5ELD"
    }

Note we don't get a ticket group.

I'm thinking the processing logic we want to do the following.

  1. Catch response from Stakwork to object response
  2. Look up the previous ticket by response.ticketUUID
  3. New ticket created with
    a. ticketUUID = new()
    b. ticketGroup = lookup.ticketGroup
    c. ticket.description = response.description
    d. ticket.version = lookup.version +1
    e. Remaining details as per response
  4. Ticket loaded in DB
  5. Websocket message to front end to trigger refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounties bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants