Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Chat ID not sent in /hivechat/send leads to history Contamination in chat send #2197

Closed
Tracked by #2142
humansinstitute opened this issue Dec 16, 2024 · 4 comments · Fixed by #2202
Closed
Tracked by #2142
Assignees
Labels
bounties bug Something isn't working

Comments

@humansinstitute
Copy link
Contributor

humansinstitute commented Dec 16, 2024

Chat ID is posted back in message to /hivechat/send but is not present inside the handler functions which create the post to stakwork.

As such the Chatid is never passed to stakwork and the chat history is contaminated as currently it is pulling all "chat message history" where chat ID = "not set"

Likely an incorrect unmarshalling, syntax matching or other issue retrieving the chatID from the POST request body.

https://github.com/stakwork/sphinx-tribes/blob/master/handlers/chat.go#L98

Example Chat history contamination

image

Correct posting of Chat object from front end

image

@saithsab877
Copy link
Contributor

@humansinstitute assign me?

@aliraza556
Copy link
Contributor

aliraza556 commented Dec 16, 2024

@humansinstitute Please assign me?

@humansinstitute humansinstitute added bounties bug Something isn't working labels Dec 16, 2024
@humansinstitute
Copy link
Contributor Author

@MahtabBukhari - Bug on the code for send message endpoint to POst to stakwork.

@MahtabBukhari
Copy link
Contributor

@humansinstitute assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounties bug Something isn't working
Projects
None yet
4 participants