Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web socket failure on InternalServerMiddleware #2199

Closed
Tracked by #2168
kevkevinpal opened this issue Dec 16, 2024 · 3 comments · Fixed by #2200
Closed
Tracked by #2168

Web socket failure on InternalServerMiddleware #2199

kevkevinpal opened this issue Dec 16, 2024 · 3 comments · Fixed by #2200
Assignees

Comments

@kevkevinpal
Copy link
Contributor

Context

The internalServerMiddleware was causing any websocket request to fail so we need to identify the reason why and resolve that in the middleware so we can reenable it

This is the commented out middleware that is broken https://github.com/stakwork/sphinx-tribes/blob/master/routes/index.go#L144-L166

@kevkevinpal
Copy link
Contributor Author

the response on this post is similar to what we have implemented but the comment below the answer also says that it breaks hijacker which is what is used for websockets

https://stackoverflow.com/questions/53272536/how-do-i-get-response-statuscode-in-golang-middleware

@aliraza556
Copy link
Contributor

aliraza556 commented Dec 16, 2024

@kevkevinpal I am working on this issue and will provide updates shortly, meaning I will create a PR within two hours.

@kevkevinpal
Copy link
Contributor Author

@kevkevinpal I am working on this issue and will provide updates shortly, meaning I will create a PR within two hours.

I should have a fix I'm using the urfave/negroni library instead of the way its being done currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants