Lint: checks and test for missing CSS #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very good! Pylint is complaining about trailing space, can you review the Github checks and clean that up? |
|
Sorry! Pylint is clear for me now if you want to try again. (There is no extra commit because I rebased to remove the whitespace. I also just put the poetry-related epub:types in chapter-1.xhtml of the test data in alphabetical order.) |
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks to se_epub_lint.py for missing dedication and epigraph CSS. These are placed close to the checks for missing poetry CSS, after what seemed to be the end of the poetry-related checks.
Added test data, test name, and output/golden file for missing dedication and epigraph CSS as well as all the other missing styles that lint checks for (span.elision; abbreviations with se:era, se:temperature, and z3998:acronym epub:type attributes; and elements with z3998:poem, :hymn, :verse, :lyrics epub:type attributes).
Closes #612.