Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the output format of predict.py #60

Open
s-jse opened this issue Dec 4, 2020 · 2 comments
Open

Change the output format of predict.py #60

s-jse opened this issue Dec 4, 2020 · 2 comments
Labels
P3 Nice to have, not working on it for now

Comments

@s-jse
Copy link
Member

s-jse commented Dec 4, 2020

We support multiple predictions per input, and soon we will add a confidence score for each prediction. Keeping the tsv format will make things difficult down the line. I propose using jsonl instead.

@gcampax
Copy link
Contributor

gcampax commented Dec 4, 2020

jsonl means one JSON blob per line right? I don't mind. One of the requirements is being able to concatenate files, and process files line by line in a streaming fashion, so this will still work. A single JSON blob on the other hand would not work, because Python has no streaming JSON library.

@Mehrad0711
Copy link
Member

Yes. I'm much in favor of it. More intuitive to index, plus bootleg uses jsonl so I can drop the conversion between jsonl and tsv.

@nrser nrser added the P3 Nice to have, not working on it for now label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Nice to have, not working on it for now
Projects
None yet
Development

No branches or pull requests

4 participants