Just a few things. #255
Open
Just a few things. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please duplicate this for MC1.8 before I merge. thanks. |
…ve NEI handle the hiding of names the same as adding them, regarding logging anyway. Fix stanhebben#239 regarding to blockHardness in a reobfuscated environement. Add additional check for if the keyboard hasn't been created yet to the ForgeEventHandler, this stops an error from being thrown querying the keystate of shift when theres no keyboard device created.
|
This should be good to go in all environments and will resolve #239 when pulled. I tested with http://hastebin.com/navajineto.xml all of which appeared to work in 1.8 and 1.7 -1 unbreakable and zero breaks instantly. Would you like me to add harvest level support as well? |
|
Please can you add back the log file to where it was, it will just confuse users if it is moved, once that is done, I will pull this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm also planning on working on anyDamage() support for things in IOreDictEntry entries. But if you want to fix the block hardness and a weird /mt hand issue that occurs when the server tries to copy into a headless clipboard that doesn't exist feel free to merge this.