Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using KiTrack for forward STAR tracking #1

Open
plexoos opened this issue Oct 30, 2019 · 2 comments
Open

Using KiTrack for forward STAR tracking #1

plexoos opened this issue Oct 30, 2019 · 2 comments

Comments

@plexoos
Copy link
Member

plexoos commented Oct 30, 2019

I reviewed the proposed integration of KiTrack into the STAR framework as implemented in this repository https://github.com/klendathu2k/stroot-forward-tracker/tree/master/StRoot/StgUtil and here are a few comments:

  • Hiding selected code (without the license, credits, and history) from the KiTrack package in StRoot/StgUtil does not look to me as a good idea. KiTrack seems well maintained and can be installed by itself with CMake. Perhaps, we should include it as an external package into our CMake-base STAR build.

  • The differences between KiTrack and the proposed StRoot/StgUtil seem minor and I am not sure about their value. It is more valuable if we base our work on the official KiTrack release

  • I agree that for our purposes KiTrack does not need to depend on other packages in iLCSoft. It looks that this dependency can be easily broken and I will make the appropriate changes in this fork

@klendathu2k @jdbrice

@klendathu2k
Copy link

klendathu2k commented Oct 30, 2019 via email

@plexoos
Copy link
Member Author

plexoos commented Oct 30, 2019

I understand you are new to git and github... but forking someone's repository is not hard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants