Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Imports and Nits #5

Open
drspacemn opened this issue Jul 8, 2022 · 0 comments
Open

Imports and Nits #5

drspacemn opened this issue Jul 8, 2022 · 0 comments

Comments

@drspacemn
Copy link

drspacemn commented Jul 8, 2022

Moving PR comments to this issue.

Suggest CamelCase interface names as follows cairo-lang.org and OZ naming conventions.

Remove unused imports.
And import OZ utils from openzeppelin.token.erc20.library import ERC20

Can remove internal tempvar binding with return in the if block.

Nit: suggest removing _storage from variables annotated @storage_variable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant