Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compute Storage Tries and Contracts Trie together #330

Closed
wants to merge 2 commits into from
Closed

feat: compute Storage Tries and Contracts Trie together #330

wants to merge 2 commits into from

Conversation

amosStarkware
Copy link
Contributor

@amosStarkware amosStarkware commented Jul 29, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

@amosStarkware amosStarkware self-assigned this Jul 29, 2024
@amosStarkware amosStarkware changed the title feature: compute Storage Tries and Contracts Trie together feat: compute Storage Tries and Contracts Trie together Jul 29, 2024
@amosStarkware amosStarkware force-pushed the amos/recursive_contracts_trie branch from a1d775c to b0244fa Compare July 29, 2024 13:47
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.75130% with 124 lines in your changes missing coverage. Please review.

Project coverage is 69.12%. Comparing base (6236ba9) to head (8d101ff).

Files Patch % Lines
...ter/src/patricia_merkle_tree/filled_tree/forest.rs 0.00% 61 Missing ⚠️
...itter/src/patricia_merkle_tree/filled_tree/tree.rs 67.64% 20 Missing and 13 partials ⚠️
...mmitter/src/patricia_merkle_tree/node_data/leaf.rs 0.00% 24 Missing ⚠️
crates/committer/src/patricia_merkle_tree/types.rs 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   70.03%   69.12%   -0.91%     
==========================================
  Files          38       38              
  Lines        2109     2196      +87     
  Branches     2109     2196      +87     
==========================================
+ Hits         1477     1518      +41     
- Misses        562      598      +36     
- Partials       70       80      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amosStarkware amosStarkware force-pushed the amos/recursive_contracts_trie branch 3 times, most recently from 8b2e7d9 to 41cc290 Compare July 29, 2024 15:04
@amosStarkware amosStarkware force-pushed the amos/recursive_contracts_trie branch from 41cc290 to 8d101ff Compare July 30, 2024 08:49
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.231 ms 35.679 ms 36.232 ms]
change: [+1.2114% +3.1135% +5.0420%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severe

full_committer_flow performance regressed!
full_committer_flow time: [29.327 ms 29.386 ms 29.449 ms]
change: [+1.2898% +1.5459% +1.7942%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

@amosStarkware amosStarkware deleted the amos/recursive_contracts_trie branch August 6, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amosStarkware amosStarkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amosStarkware @codecov-commenter