Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert gen #218

Merged
merged 1 commit into from
Dec 4, 2024
Merged

assert gen #218

merged 1 commit into from
Dec 4, 2024

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Dec 1, 2024

This change is Reviewable

This was referenced Dec 1, 2024
Merged
@ohad-starkware ohad-starkware mentioned this pull request Dec 2, 2024
This was referenced Dec 2, 2024
@ohad-starkware ohad-starkware force-pushed the ohad/jnz branch 2 times, most recently from 1be6661 to 79d557e Compare December 3, 2024 12:07
@ohad-starkware ohad-starkware changed the base branch from ohad/jnz to graphite-base/218 December 3, 2024 12:42
@ohad-starkware ohad-starkware changed the base branch from graphite-base/218 to main December 3, 2024 12:43
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 12 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)


stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs line 120 at r3 (raw file):

        )]);

        // Either flag op1_base_fp is on or flag op1_base_ap is on.

This comment comes from the air infra?


stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs line 126 at r3 (raw file):

        // mem_verify_equal.

why do you have new line here?

Copy link
Contributor Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs line 120 at r3 (raw file):

Previously, shaharsamocha7 wrote…

This comment comes from the air infra?

yes


stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs line 126 at r3 (raw file):

Previously, shaharsamocha7 wrote…

why do you have new line here?

these are block docs rather than step docs

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware mentioned this pull request Dec 4, 2024
@ohad-starkware ohad-starkware merged commit 91e9a7c into main Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants