-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert gen #218
assert gen #218
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
05aef95
to
0577f30
Compare
98f9252
to
a01a3a8
Compare
0577f30
to
830943c
Compare
a01a3a8
to
afeb14b
Compare
830943c
to
b3d5be5
Compare
afeb14b
to
5df2198
Compare
b3d5be5
to
b111819
Compare
5df2198
to
e270e47
Compare
b111819
to
42ff453
Compare
e270e47
to
9106f69
Compare
42ff453
to
577f6dd
Compare
1be6661
to
79d557e
Compare
577f6dd
to
02a5784
Compare
79d557e
to
97580b8
Compare
02a5784
to
429e2dd
Compare
97580b8
to
859ab14
Compare
429e2dd
to
340e0f1
Compare
340e0f1
to
25f8014
Compare
25f8014
to
d5ca720
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 12 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)
stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs
line 120 at r3 (raw file):
)]); // Either flag op1_base_fp is on or flag op1_base_ap is on.
This comment comes from the air infra?
stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs
line 126 at r3 (raw file):
// mem_verify_equal.
why do you have new line here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs
line 120 at r3 (raw file):
Previously, shaharsamocha7 wrote…
This comment comes from the air infra?
yes
stwo_cairo_prover/crates/prover/src/components/assert_eq_opcode_is_double_deref_f_is_imm_f/component.rs
line 126 at r3 (raw file):
Previously, shaharsamocha7 wrote…
why do you have new line here?
these are block docs rather than step docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
This change is