Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add opcode #220

Merged
merged 1 commit into from
Dec 5, 2024
Merged

add opcode #220

merged 1 commit into from
Dec 5, 2024
+5,312 −4

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Dec 2, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

This was referenced Dec 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ohad-starkware Graphite App
Copy link
Contributor Author

ohad-starkware commented Dec 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ohad-starkware ohad-starkware mentioned this pull request Dec 2, 2024
Merged
@ohad-starkware ohad-starkware force-pushed the ohad/add_opcode_gen branch 3 times, most recently from 720720f to 72a4ddf Compare December 2, 2024 07:27
This was referenced Dec 2, 2024
Merged
Merged
@ohad-starkware ohad-starkware mentioned this pull request Dec 4, 2024
Merged
@ohad-starkware ohad-starkware mentioned this pull request Dec 4, 2024
Merged
@ohad-starkware ohad-starkware force-pushed the ohad/mul branch 2 times, most recently from 47f1c98 to 502d05b Compare December 4, 2024 12:08
shaharsamocha7
shaharsamocha7 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 15 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware force-pushed the ohad/mul branch 2 times, most recently from 4c8acfe to b95f332 Compare December 5, 2024 13:46
@ohad-starkware ohad-starkware mentioned this pull request Dec 5, 2024
Open
@ohad-starkware Graphite App
Copy link
Contributor Author

ohad-starkware commented Dec 5, 2024 •
edited
Loading

Merge activity

  • Dec 5, 10:57 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 10:59 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 5, 11:03 AM EST: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware changed the base branch from ohad/mul to graphite-base/220 December 5, 2024 15:57
@ohad-starkware ohad-starkware changed the base branch from graphite-base/220 to main December 5, 2024 15:57
@ohad-starkware ohad-starkware merged commit 603b6e7 into main Dec 5, 2024
5 of 6 checks passed
This was referenced Dec 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharsamocha7 shaharsamocha7 shaharsamocha7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohad-starkware @shaharsamocha7