tracking relations

[ohad-starkware]

This change is 

[ohad-starkware]

• tracking relations #229 : 2 dependent PRs (#231 , #233 ) 👈 (View in Graphite)
• call #222
• is first and row bounds relaxations #228
• jump #221
• add opcode #220
• mul #219
• assert gen #218
• jnz gen #217
• migrated opcodes air out of cairo air #216
• add_ap components #215
• update verify generic and ret from auto gen #214
• snake case generic and verify #209
• renamed relations #208
• pub use for memory and range checks #207
• renamed memory components #206
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Alon-Ti]

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/prover/src/cairo_air/debug.rs line 46 at r2 (raw file):

    });
    let evals = &evals.as_ref();
    let trace = &(evals).into();

Check if there's a less confusing way to write this ((&evals)?)

---

stwo_cairo_prover/crates/prover/src/cairo_air/debug.rs line 67 at r2 (raw file):

        );
    }
    for claim in claim.opcodes.add_f_t.clone() {

Macro these out?

Maybe even possible with regular code if Evals had some sort of common trait.

[ohad-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Alon-Ti)

---

stwo_cairo_prover/crates/prover/src/cairo_air/debug.rs line 46 at r2 (raw file):

Previously, Alon-Ti wrote…

Check if there's a less confusing way to write this ((&evals)?)

Done.

---

stwo_cairo_prover/crates/prover/src/cairo_air/debug.rs line 67 at r2 (raw file):

Previously, Alon-Ti wrote…

Macro these out?

Maybe even possible with regular code if Evals had some sort of common trait.

evals need to expose n_calls for that
I think we would have that eventually, and I don't want to write a macro for this (different attributes). added a TODO stating I'm not happy about it.

[Alon-Ti]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/prover/src/cairo_air/debug.rs line 67 at r2 (raw file):

Previously, ohad-starkware (Ohad) wrote…

evals need to expose n_calls for that
I think we would have that eventually, and I don't want to write a macro for this (different attributes). added a TODO stating I'm not happy about it.

Makes sense.

[Alon-Ti]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

[Alon-Ti]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

[ohad-starkware]

Merge activity

• Dec 8, 10:20 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 8, 10:23 AM EST: Graphite rebased this pull request as part of a merge.
• Dec 8, 10:27 AM EST: A user merged this pull request with Graphite.