Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum Euslisp interface to baxterlgv7 #2616

Merged
merged 7 commits into from
Jan 7, 2018
Merged

Conversation

pazeshun
Copy link
Collaborator

What I did

  1. Make baxterlgv7.l and baxterlgv7-interface.l by copying baxter.l and baxter-interface.l
  2. Enable to move left gripper_v7
    • Change file name in require
    • Change class name
    • Fix how to move fingers because each finger of left gripper_v7 model has 3 joints (previous: 2 joints).
    • In order to move *baxter* realistically, I added some trick in :hand-grasp-pose as 2 joints out of 3 don't move separately.
  3. Fix :start-grasp and :stop-grasp to move in left gripper_v7

What I haven't finished

  • Move whole baxterlgv7
  • Add moveit config of baxterlgv7

@pazeshun pazeshun self-assigned this Dec 28, 2017
@knorth55
Copy link
Member

it looks your code is correct, but i could not check it.
Can you add test code?
Or can you add video that proves these code can surely moves your gripper?

@pazeshun
Copy link
Collaborator Author

Sorry for lacking test code.
I'll make test code checking following

  • Generation of *baxter* and *ri*
  • Finger movement in :hand-grasp-pre-pose and :hand-grasp-pose

Thank you for nice suggestion about video.
I'll take video proving *ri* function.

@pazeshun
Copy link
Collaborator Author

pazeshun commented Jan 6, 2018

Add test code.
Other minor fix: Add baxter-interface test to CMakeLists.txt (lacking in #2500)

@pazeshun
Copy link
Collaborator Author

pazeshun commented Jan 6, 2018

@pazeshun
Copy link
Collaborator Author

pazeshun commented Jan 6, 2018

Test passed.
@knorth55 Currently I can't take video because new gripper is broken and fixing takes time.
Please approve this PR if you feel ok for lacking video.

@knorth55 knorth55 merged commit b4b8b1c into master Jan 7, 2018
@pazeshun
Copy link
Collaborator Author

pazeshun commented Jan 7, 2018

Thanks!

@pazeshun pazeshun deleted the add-gripper-v7-eus branch January 7, 2018 10:25
@pazeshun pazeshun mentioned this pull request Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants