-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align core types with execution spec #733
Merged
Merged
Commits on Sep 25, 2024
-
Align core types with execution spec
Since these types were written, we've gained an executable spec: https://github.com/ethereum/execution-specs This PR aligns some of the types we use with this spec to simplify comparisons and cross-referencing. Using a `distinct` type is a tradeoff between nim ergonomics, type safety and the ability to work around nim quirks and stdlib weaknesses. In particular, it allows us to overload common functions such as `hash` with correct and performant versions as well as maintain control over string conversions etc at the cost of a little bit of ceremony when instantiating them. Apart from distinct byte types, `Hash32`, is introduced in lieu of the existing `Hash256`, again aligning this commonly used type with the spec which picks bytes rather than bits in the name.
Configuration menu - View commit details
-
Copy full SHA for b4d1ef5 - Browse repository at this point
Copy the full SHA b4d1ef5View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d61622f - Browse repository at this point
Copy the full SHA d61622fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34eaa91 - Browse repository at this point
Copy the full SHA 34eaa91View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9ae016 - Browse repository at this point
Copy the full SHA e9ae016View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3c9536 - Browse repository at this point
Copy the full SHA a3c9536View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e275a7 - Browse repository at this point
Copy the full SHA 9e275a7View commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 83d639d - Browse repository at this point
Copy the full SHA 83d639dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdb3601 - Browse repository at this point
Copy the full SHA cdb3601View commit details -
Configuration menu - View commit details
-
Copy full SHA for 899c0f7 - Browse repository at this point
Copy the full SHA 899c0f7View commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 13f7102 - Browse repository at this point
Copy the full SHA 13f7102View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d1cb5 - Browse repository at this point
Copy the full SHA 68d1cb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b1b651 - Browse repository at this point
Copy the full SHA 9b1b651View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3908931 - Browse repository at this point
Copy the full SHA 3908931View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.