Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add array/base/broadcasted-quinary4d #3267

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Neerajpathak07
Copy link
Contributor

Resolves #3171

Description

What is the purpose of this pull request?

This pull request:

  • adds implementation for array/base/broadcasted-quinary4d

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 26, 2024

Coverage Report

Package Statements Branches Functions Lines
array/base/broadcasted-quinary4d $\color{green}328/328$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}328/328$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 changed the title feat: add array/base/broadcasted-quinary3d feat: add array/base/broadcasted-quinary4d Nov 26, 2024
@AbhijitRaut04
Copy link
Contributor

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 29, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 29, 2024
Comment on lines +199 to +208
k2 = 0;
m2 = 0;
n2 = 0;
p2 = 0;
x2 = x[ j3 ];
y2 = y[ k3 ];
z2 = z[ m3 ];
w2 = w[ n3 ];
u2 = u[ p3 ];
v2 = v[ i3 ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
k2 = 0;
m2 = 0;
n2 = 0;
p2 = 0;
x2 = x[ j3 ];
y2 = y[ k3 ];
z2 = z[ m3 ];
w2 = w[ n3 ];
u2 = u[ p3 ];
v2 = v[ i3 ];
k2 = 0;
m2 = 0;
n2 = 0;
p2 = 0;
x2 = x[ j3 ];
y2 = y[ k3 ];
z2 = z[ m3 ];
w2 = w[ n3 ];
u2 = u[ p3 ];
v2 = v[ i3 ];

Comment on lines +210 to +220
j1 = 0;
k1 = 0;
m1 = 0;
n1 = 0;
p1 = 0;
x1 = x2[ j2 ];
y1 = y2[ k2 ];
z1 = z2[ m2 ];
w1 = w2[ n2 ];
u1 = u2[ p2 ];
v1 = v2[ i2 ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
j1 = 0;
k1 = 0;
m1 = 0;
n1 = 0;
p1 = 0;
x1 = x2[ j2 ];
y1 = y2[ k2 ];
z1 = z2[ m2 ];
w1 = w2[ n2 ];
u1 = u2[ p2 ];
v1 = v2[ i2 ];
j1 = 0;
k1 = 0;
m1 = 0;
n1 = 0;
p1 = 0;
x1 = x2[ j2 ];
y1 = y2[ k2 ];
z1 = z2[ m2 ];
w1 = w2[ n2 ];
u1 = u2[ p2 ];
v1 = v2[ i2 ];

Comment on lines +222 to +237
j0 = 0;
k0 = 0;
m0 = 0;
n0 = 0;
p0 = 0;
x0 = x1[ j1 ];
y0 = y1[ k1 ];
z0 = z1[ m1 ];
w0 = w1[ n1 ];
u0 = u1[ p1 ];
v0 = v1[ i1 ];
for ( i0 = 0; i0 < S0; i0++ ) {
v0[ i0 ] = fcn( x0[ j0 ], y0[ k0 ], z0[ m0 ], w0[ n0 ], u0[ p0 ] ); // eslint-disable-line max-len
j0 += dx0;
k0 += dy0;
m0 += dz0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
j0 = 0;
k0 = 0;
m0 = 0;
n0 = 0;
p0 = 0;
x0 = x1[ j1 ];
y0 = y1[ k1 ];
z0 = z1[ m1 ];
w0 = w1[ n1 ];
u0 = u1[ p1 ];
v0 = v1[ i1 ];
for ( i0 = 0; i0 < S0; i0++ ) {
v0[ i0 ] = fcn( x0[ j0 ], y0[ k0 ], z0[ m0 ], w0[ n0 ], u0[ p0 ] ); // eslint-disable-line max-len
j0 += dx0;
k0 += dy0;
m0 += dz0;
j0 = 0;
k0 = 0;
m0 = 0;
n0 = 0;
p0 = 0;
x0 = x1[ j1 ];
y0 = y1[ k1 ];
z0 = z1[ m1 ];
w0 = w1[ n1 ];
u0 = u1[ p1 ];
v0 = v1[ i1 ];
for ( i0 = 0; i0 < S0; i0++ ) {
v0[ i0 ] = fcn( x0[ j0 ], y0[ k0 ], z0[ m0 ], w0[ n0 ], u0[ p0 ] ); // eslint-disable-line max-len
j0 += dx0;
k0 += dy0;
m0 += dz0;

Comment on lines +238 to +247
n0 += dw0;
p0 += du0;
}
j1 += dx1;
k1 += dy1;
m1 += dz1;
n1 += dw1;
p1 += du1;
}
j2 += dx2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
n0 += dw0;
p0 += du0;
}
j1 += dx1;
k1 += dy1;
m1 += dz1;
n1 += dw1;
p1 += du1;
}
j2 += dx2;
n0 += dw0;
p0 += du0;
}
j1 += dx1;
k1 += dy1;
m1 += dz1;
n1 += dw1;
p1 += du1;
}
j2 += dx2;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/broadcasted-quinary4d
3 participants