card title color (colorEditText) invisible after Android common update

[Ornanovitch]

This issue respects the following points:

• I have read the FAQ
• I have searched for existing issues
• The issue affects the Deck Android app, neither the Deck server app nor the Nextcloud Android app.

Describe the bug

Follow-up after #1675 and nextcloud/android-common#502

1. Click on a card
2. You can't read the title but you can select/edit it

Screenshot

The colorEditText function seemed to be in cause because we found some problems into it, but those had been fixed without solving the issue in my tests.

Here is the issue:

nextcloud-deck/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/EditActivity.java

Lines 280 to 294 in 8cea58a

	private void applyTheme(int color) {
	final var navigationIcon = binding.toolbar.getNavigationIcon();
	if (navigationIcon == null) {
	DeckLog.error("Expected navigationIcon to be present.");
	} else {
	DrawableCompat.setTint(binding.toolbar.getNavigationIcon(), ContextCompat.getColor(this, R.color.onSurface));
	}
	final var utils = ThemeUtils.of(color, this);
	utils.platform.themeStatusBar(this);
	utils.material.themeToolbar(binding.toolbar);
	utils.platform.colorEditText(binding.title);
	utils.material.themeTabLayoutOnSurface(binding.tabLayout);
	}

The interesting thing is that this element is the only place where colorEditText function is used in the whole app. Plenty of other EditText elements are used without this kind of theming parameter, and are working normally.

Expected behavior

Title should be readable

Deck Android version

dev

Deck server version

not relevent

Nextcloud Android version

not relevent

Nextcloud version

not relevent

Device

Samsung Galacy A5 2017

Android Version

12

App Store

• Google Play Store
• Google Play Store (Beta channel)
• F-Droid
• Huawei App Gallery

Stacktrace

No response

[stefan-niedermann]

Are you absolutely sure regarding the correct tested lib version? There is a transitive dependency to the lib from nextcloud-commons, and I suspect it will pick the there used release version over the not-released version directly embedded in the Deck Android App.

[Ornanovitch]

Are you absolutely sure regarding the correct tested lib version? There is a transitive dependency to the lib from nextcloud-commons, and I suspect it will pick the there used release version over the not-released version directly embedded in the Deck Android App.

I didn't suspect a version problem on the lib side, but you're right, it's too strange to not be investigated! However right now I don't know how to inspect the library version in use after a build. I'll try to check this out.

[AndyScherzinger]

I published 0.23.1, so the simplest thing would be to bump the lib version in all places to this one, than no matter which one gets picked it is always the same version.

[stefan-niedermann]

I'll publish new versions this weekend 👍

[stefan-niedermann]

Alright, nextcloud-commons:2.3.1 has been published and it includes android-common:0.23.1

[Ornanovitch]

It works with android-common:0.23.1! 🎆