Feature Idea: Soft delete

[leipert]

If one uses icloud-photos-sync for backup purposes, it'd be great to have a soft-delete mode which moves deleted files into a separate folder rather than just deleting them from the file system.

Probably would "just" be a CLI flag and then instead of an rm, one would move the file.

Probably here:

icloud-photos-sync/app/src/lib/photos-library/photos-library.ts

Lines 292 to 295 in 9c14564

	async deleteAsset(asset: Asset) {
	Resources.logger(this).info(`Deleting asset ${asset.getDisplayName()}`);
	await fs.promises.rm(asset.getAssetFilePath(), {force: true});
	}

and here:

icloud-photos-sync/app/src/lib/photos-library/photos-library.ts

Lines 488 to 489 in 9c14564

	fs.rmSync(uuidPath, {recursive: true});
	fs.unlinkSync(albumNamePath);

I might have some time to look at this, but just wanted to leave the idea here.

[steilerDev]

hey @leipert - that sounds like a reasonable additional feature (and shouldnt be too hard)... let me add it to the backlog

[steilerDev]

I've created a separate issue (#354) to explain my proposal for a new library version that should resolve this issue. Would therefore love to get your feedback on there.