Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The database is public, intentional? #2

Open
Nogbit opened this issue Apr 1, 2019 · 0 comments
Open

The database is public, intentional? #2

Nogbit opened this issue Apr 1, 2019 · 0 comments

Comments

@Nogbit
Copy link

Nogbit commented Apr 1, 2019

While I like the repo layout and the modules, the diagram should show a direct line from the internet to the database since the database server is given a public IP.

in gcp-terraform-workshop/terraform/modules/db/main.tf (of the task6 branch) it has

//
  ip_configuration {
    ipv4_enabled = "true"
//

The terraform docs for that say for ipv4_enabled "Whether this Cloud SQL instance should be assigned a public IPV4 address.", similar for GCP docs. And, since you allow 0.0.0.0/0 to that db then all the security and firewalling you've done for the subnets is helping everything but the db server.

Not sure if it was intentional or not, again, nice job on the project/repo layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant