Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug with request_reset() #543

Closed
timbit123 opened this issue Nov 9, 2023 · 2 comments
Closed

Small bug with request_reset() #543

timbit123 opened this issue Nov 9, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@timbit123
Copy link

When we are trying to render a second video, we are creating a new system object and also just the be safe, we are also calling request_reset() but the reset is only called after the first frame is created (during feed_frame)

The issue is that data::frame::next_id_ was not reset to 0 before de creation of the first frame in create_monocular_frame

we are manually resetting it, but I would suggest maybe adding something to reset the value during the system constructor?

Thank you
Tim

@timbit123 timbit123 added the bug Something isn't working label Nov 9, 2023
@ymd-stella
Copy link
Contributor

ymd-stella commented Nov 10, 2023

Essentially, data::frame::next_id_ designed to be static seems to obscure handling of initialization and destruction. I'll see if I can move it to system::next_id_. Thanks for the report.

@ymd-stella ymd-stella self-assigned this Feb 25, 2024
@ymd-stella
Copy link
Contributor

ymd-stella commented Feb 25, 2024

Done. #570

we can reset next_frame_id_ to 0 by destroying system.

In addition, reset() will not set next_frame_id_ to 0 after this change. I removed this feature because I thought it was unnecessary and confusing, but if you need it, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants