Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make soroban-rpc depend on stellar-core specific version #195

Merged
merged 8 commits into from
Apr 13, 2023

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Apr 12, 2023

Fixes #194
If we end up doing this we need to update the pipelines repo to sed the _CORE_VERSION_ into place.

@paulbellamy paulbellamy force-pushed the 194/soroban-rpc-core-dep branch from 659f7f9 to 1682460 Compare April 12, 2023 14:47
@paulbellamy paulbellamy marked this pull request as ready for review April 12, 2023 14:51
@paulbellamy paulbellamy requested a review from jacekn April 12, 2023 14:51
Copy link
Contributor

@jacekn jacekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments but they are non-blocking.
The only thing important to address before golive IMO is http vs https.

stellar-soroban-rpc/debian/stellar-soroban-rpc.default Outdated Show resolved Hide resolved
stellar-soroban-rpc/debian/stellar-soroban-rpc.default Outdated Show resolved Hide resolved
stellar-soroban-rpc/debian/stellar-soroban-rpc.links Outdated Show resolved Hide resolved
stellar-soroban-rpc/stellar-core_captive-futurenet.cfg Outdated Show resolved Hide resolved
@paulbellamy paulbellamy merged commit 581171b into master Apr 13, 2023
@paulbellamy paulbellamy deleted the 194/soroban-rpc-core-dep branch April 13, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RPC debian package to install stellar-core
2 participants