Misc fixes/improvements for tx generator. #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
reviewed
Nov 4, 2024
dmkozh
force-pushed
the
apply_load_fixes
branch
from
6739bbb to
3df58e0
Compare
The improvements include: - Properly close the ledgers for compatibility with BLDB - Increased I/O modeled instructions to cover larger writes - Account for the cost recalibration when setting up a test network config - Add per-ledger modelled/real insns ratio metrics to reduce variance - Add more logs to `apply-load` command Also added a smoke test for the apply load utility.
…it randomly broke the externalize test). Also update the externalize test itself to cover the relevant protocol versions (prev and curr) instead of some fixed ones.
The reason for the change is the added costs recalibration. This also led to a host fn succeeding instead of failing.
dmkozh
force-pushed
the
apply_load_fixes
branch
from
4763ad4 to
dc19ff2
Compare
sisuresh
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Misc fixes/improvements for tx generator. The improvements include:
apply-loadcommandAlso added a smoke test for the apply load utility.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)