Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden index reads #4547

Closed
wants to merge 28 commits into from
Closed

Conversation

SirTyson
Copy link
Contributor

Description

Resolves #4546

This change calls fsync after writing BucketIndex files. This change was slightly more involved than expected. There's no way to fall fsync on files opened via std::fstream, so I had to implement a new cereal archive type that accepts our own asio::buffered_write_streamasio::buffered_write_stream backed stream type.

Rebased on #4403.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket index files corruption
1 participant