-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden publishing #4555
Merged
Merged
Harden publishing #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
previously approved these changes
Nov 22, 2024
marta-lokhova
force-pushed
the
PublishFsync
branch
from
November 22, 2024 19:24
31d3d24
to
003ab36
Compare
marta-lokhova
force-pushed
the
PublishFsync
branch
from
November 22, 2024 19:29
003ab36
to
375cb37
Compare
graydon
previously approved these changes
Nov 22, 2024
marta-lokhova
force-pushed
the
PublishFsync
branch
2 times, most recently
from
November 22, 2024 20:07
5762fe4
to
51f7d0d
Compare
marta-lokhova
force-pushed
the
PublishFsync
branch
from
November 22, 2024 20:09
51f7d0d
to
81aafab
Compare
graydon
previously approved these changes
Nov 22, 2024
SirTyson
reviewed
Nov 22, 2024
SirTyson
reviewed
Nov 22, 2024
marta-lokhova
force-pushed
the
PublishFsync
branch
from
November 22, 2024 20:54
81aafab
to
5c63e7b
Compare
SirTyson
reviewed
Nov 22, 2024
SirTyson
previously approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the MODE_DISABLES_FSYNC
change.
SirTyson
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
Additionally, I added a few more thing to aid debugging, such as printing checkpoint files with dump-xdr and an offline command to dump all checkpoints scheduled to publish.