Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary dot prefix and suffix on ProdHostedZone and Domain #65

Open
PaulDuvall opened this issue Feb 23, 2016 · 1 comment
Open

Unnecessary dot prefix and suffix on ProdHostedZone and Domain #65

PaulDuvall opened this issue Feb 23, 2016 · 1 comment
Labels
Medium Priority

Comments

@PaulDuvall
Copy link
Contributor

Currently, the ProdHostedZone parameter requires a . prefix in the Hosted Zone. This is easy to overlook and will cause users problems. The Domain requires a . suffix after the Hosted Zone name. Both of these are necessary, but we probably shouldn't require users to care about these details. We should automatically add the . where necessary.
@PaulDuvall
Copy link
Contributor Author

Use some variation of this: https://github.com/stelligent/dromedary-serverless/blob/master/pipeline/cfn/master.json#LL10-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Medium Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulDuvall