Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking other conditions done when trashchecker returns 'false' #1

Open
Amelsfort opened this issue Nov 21, 2016 · 3 comments
Open

Comments

@Amelsfort
Copy link

Amelsfort commented Nov 21, 2016

In my 'and'-column I have several checks which need to be checked before telling me to put the trash outside. The first check is to see if the trash gets collected the next day, then if it's after 18:00 and then there's a confirmation-check (asking me if I put the trash out already).

A little while ago, Homey was updated with functionality to check the conditions one after the other instead of all in parallel. Unfortunately, this doesn't seem to be working for the trashchecker: even when the trash is not collected the next day (when testing the card also shows a red cross), the other checks are still performed! Including the confirmation, which results in Homey asking me if I put the garbage out every night after 18:00.

Is this something that needs to be fixed in this app? Some way to indicate these checks have to be performed one after the other? Or it this an issue in Homey?

@stemmr
Copy link
Owner

stemmr commented Dec 1, 2016

Hmmm that is strange... Does everything work fine if you don't check one after each other? It would be quite strange if they added a breaking change in something so fundamental as conditional execution, I'll take a look into it.

@Amelsfort
Copy link
Author

What do you mean with not checking one after each other?
When I test the flow now, it performs all checks even when the trashcan-check is negative:
image

@Amelsfort
Copy link
Author

Never mind! It seems to be fixed by the 1.0.2 update of Homey!

stemmr pushed a commit that referenced this issue Dec 21, 2016
Added two more trash API's (Hellendoorn and Twentemilieu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants