Make list access private

[stephanstapel]

• Taxes
• ServiceCharges
• TradeLineItems
• ReceivableSpecifiedTradeAccountingAccounts
• CreditorBankAccounts
• DebitorBankAccounts

[tobitege]

Would you mind to clarify if you meant only write list access?
Such changes could have huge (breaking) consequences for any 3rd party software which uses them for their own purposes (special processing/validation/cleanup).

[stephanstapel]

I mean things like:

ZUGFeRD-csharp/ZUGFeRD/InvoiceDescriptor.cs

Line 65 in fff9e12

public List<AdditionalReferencedDocument> AdditionalReferencedDocuments { get; internal set; } = new List<AdditionalReferencedDocument>();

and

ZUGFeRD-csharp/ZUGFeRD/InvoiceDescriptor.cs

Line 711 in fff9e12

public void AddAdditionalReferencedDocument(string id, AdditionalReferencedDocumentTypeCode typeCode, DateTime? issueDateTime = null, string name = null, ReferenceTypeCodes referenceTypeCode = ReferenceTypeCodes.Unknown, byte[] attachmentBinaryObject = null, string filename = null)

I am aware of the impact, that's why I'm using semantic versioning for the component.

[tobitege]

That's what I thought, thanks for the clarification. 😃