Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Submit to history #11

Open
stephtr opened this issue Apr 2, 2023 · 2 comments
Open

Discussion: Submit to history #11

stephtr opened this issue Apr 2, 2023 · 2 comments

Comments

@stephtr
Copy link
Owner

stephtr commented Apr 2, 2023

Currently, Qalculator submits the current calculation to the history, as soon as one presses Enter or the input field looses focus. Neither am I completely happy with this behaviour, nor do I have a clear opinion about it.

I'm open for your opinions!

@stephtr stephtr pinned this issue Apr 2, 2023
@vlad2305m
Copy link

vlad2305m commented Apr 5, 2023

Logging everything into the history is a great feature, and it should stay that way.
I feel like the current appearance of the history is a bit unhelpful. Personally I would expect only the first few entries to be those big cards, and the rest to collapse to 1-2 lines of font 14 each, 5-10px line spacing. (Scaled for high-DPI devices, of course). Maybe they could pop back into the card form one at a time as one scrolls downwards.
Also I seem to be missing something, but it is not clear to me how to access the list of bookmarks.

@stephtr
Copy link
Owner Author

stephtr commented Apr 6, 2023

Good idea, I'll experiment on that some time soon.

Besides optical clues, the bookmarking currently only protects against deletion, since I limited the history to 30 entries. My plan was to add a toggle history | bookmarks only, but I didn't implement it to not introduce additional visual clutter.

Such a switch however might be also beneficial for switching submission mode ("history" with blur and "bookmarks only" only on enter).

@stephtr stephtr unpinned this issue Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants