Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: treesitter support for swift #428

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: treesitter support for swift #428

merged 1 commit into from
Dec 3, 2024
+939 −0

Conversation

simpleliujl
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a review from stevearc November 28, 2024 04:15
@simpleliujl simpleliujl force-pushed the master branch 5 times, most recently from 390edad to 7a222ca Compare November 28, 2024 13:07
stevearc
stevearc approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, one question

tests/treesitter/swift_test.swift Outdated

// TODO: Some stuff
// FIXME: Some fix
// MARK: Some mark
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason these are included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not necessory, I will delete them.

@github-actions github-actions bot requested a review from stevearc December 3, 2024 03:56
@stevearc
Copy link
Owner

stevearc commented Dec 3, 2024

Thanks for the PR!

@stevearc stevearc merged commit fd7fbe3 into stevearc:master Dec 3, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevearc stevearc Awaiting requested review from stevearc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simpleliujl @stevearc