Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: set the open_output component by default #310

Closed
1 task done
Zeioth opened this issue Jun 6, 2024 · 3 comments
Closed
1 task done

feature request: set the open_output component by default #310

Zeioth opened this issue Jun 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Zeioth
Copy link

Zeioth commented Jun 6, 2024

Did you check existing requests?

  • I have searched the existing issues

Describe the feature

Focus should go to the latest started task by default.

Provide background

I'm opening this so we can close #299 #302 and Zeioth/compiler.nvim#45 (comment)

What is the significance of this feature?

nice to have

Additional details

No response

@stevearc
Copy link
Owner

stevearc commented Jun 9, 2024

I've been thinking about this for a while, and I don't think we want to add open_output to all tasks by default. It's a pretty big UX change, and it would default to applying to all tasks. I think for a new user this might be fine, and obviously it helps in your situation, but it has the potential to be really quite disruptive for existing users of overseer. Imagine you have a workflow all nice and customized, and then you upgrade and windows start appearing all over the place. Now you have to dig through the commit history and/or documentation to figure out why this is happening so you can disable it. Multiply that by the number of existing users of overseer, and I don't think that amount of thrash is worth the benefit to new users.

In the example PR that I sent you, I demonstrated how you can accomplish this on your side by defining your own component alias and using that for the tasks that you create. It's a bit more work for you because you'll have to update all the locations where you create tasks, but it will have the same effect.

@stevearc stevearc added the question Further information is requested label Jun 9, 2024
@Zeioth
Copy link
Author

Zeioth commented Jun 9, 2024

Thank you for considering it Steve. Ok let's go with the PR way. I'd rather avoiding introducing the concept of components into compiler.nvim in order to reduce complexity (also I don't want it to interfere with user defined components), buuut it shouldn't be a super big deal probably.

@github-actions github-actions bot removed the question Further information is requested label Jun 9, 2024
@Zeioth
Copy link
Author

Zeioth commented Jun 9, 2024

fixed in Zeioth/compiler.nvim@96ff16b, closing.

@Zeioth Zeioth closed this as completed Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants