Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: in commit refactor: change default params of open_output component #313

Closed
Zeioth opened this issue Jun 9, 2024 · 1 comment · Fixed by Zeioth/compiler.nvim#47
Labels
bug Something isn't working

Comments

@Zeioth
Copy link

Zeioth commented Jun 9, 2024

Neovim version (nvim -v)

0.10

Operating system/version

arch linux

Describe the bug

There seem something broke in the commit bd9cc6d, because the previous commit 29dd31d seem to be working fine.

screenshot_2024-06-09_18-51-03_597997129

What is the severity of this bug?

breaking (some functionality is broken)

Steps To Reproduce

You can try it with the PR you sent to compiler.nvim.

Expected Behavior

Run without errors.

Minimal example file

No response

Minimal init.lua

No response

Additional context

No response

@Zeioth Zeioth added the bug Something isn't working label Jun 9, 2024
@Zeioth Zeioth changed the title regression: in commit bd9cc6d2cc2317b6b70b3bfb956c88d4e00c7837 regression: in commit "refactor: change default params of open_output component" Jun 9, 2024
@Zeioth Zeioth changed the title regression: in commit "refactor: change default params of open_output component" regression: in commit refactor: change default params of open_output component Jun 9, 2024
@stevearc
Copy link
Owner

stevearc commented Jun 9, 2024

My apologies, I forgot that when defining the types for the parameters that I actually do hard validation checks. I changed the type of the on_start param. I'll submit a PR to compiler.nvim to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants