New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys shouldn't be random #11

Open

stevelw opened this issue Nov 7, 2024 · 1 comment

Labels

invalid

Owner

stevelw commented Nov 7, 2024

Keys should be consistent between renders, so random numbers should not be used.

Use a reproducible UUID instead. It's suggested to use https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID

fe-nc-news/src/components/CommentList.jsx

Line 58 in 58f549c

key={comment_id ?? Math.random()}

stevelw added the invalid label

Owner Author

stevelw commented Nov 16, 2024

Use Symbol - JavaScript | MDN to generate keys for React elements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment