Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom PeripheralPins.c for Ethernet Nucleos F429ZI/F439ZI #2564

Closed
pmantoine opened this issue Nov 13, 2024 · 1 comment · Fixed by #2568
Closed

Custom PeripheralPins.c for Ethernet Nucleos F429ZI/F439ZI #2564

pmantoine opened this issue Nov 13, 2024 · 1 comment · Fixed by #2568
Labels
enhancement New feature or request
Milestone
2.9.0

Comments

@pmantoine
Copy link
Contributor

Thank you for adding Nucleo-F439ZI support in v2.8.0

We make use of the STM32Ethernet library for our networked application on both the Nucleo-F429ZI and Nucleo-F439ZI, and have discovered an issue that suggests a custom PeripheralPins.c would be the appropriate answer.

The current code in STM32Ethernet's HAL_ETH_MspInit() routine in ethernetif.cpp blasts its way over every pin associated with Ethernet in the PeripheralPins.c, leaving pins not used on the Nucleo-F4[23]9ZI boards also configured with AF attributes.

We propose that a custom PeripheralPins_NUCLEO_F4x9ZI.c file be used, which limits this initialisation to just the pins actually used on both Nucleos.

Please find attached a proposed form of the file which we've tested. Or I can inssue a suitable PR if you'd prefer.
PeripheralPins_NUCLEO_F4x9ZI.c.zip
@fpistm
Copy link
Member

fpistm commented Nov 13, 2024 •
edited
Loading

Hi @pmantoine
Yes, feel free to submit a PR especially if you have tested it. --> Done #2568

@fpistm fpistm added the enhancement New feature or request label Nov 13, 2024
@fpistm fpistm added this to the 2.9.0 milestone Nov 13, 2024
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Nov 14, 2024
@pmantoine @fpistm
variants(f4): custom peripheral pins for Nucleo-F4x9ZI
b692b17 
Fixes stm32duino#2564

Signed-off-by: pmantoine <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
@fpistm fpistm mentioned this issue Nov 14, 2024
Merged
fpistm added a commit that referenced this issue Nov 19, 2024
@pmantoine @fpistm
variants(f4): custom peripheral pins for Nucleo-F4x9ZI
339e2b9 
Fixes #2564

Signed-off-by: pmantoine <[email protected]>
Co-authored-by: Frederic Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
STM32 core based on ST HAL
Status: Done
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

variants(f4): custom peripheral pins for Nucleo-F4x9ZI fpistm/Arduino_Core_STM32
2 participants
@fpistm @pmantoine