Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LicenseRegistry to Include Default License Terms in getAttachedLicenseTerms and getAttachedLicenseTermsCount #197

Open
kingster-will opened this issue Aug 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kingster-will
Copy link

Description

The LicenseRegistry contract needs to be updated to ensure that the getAttachedLicenseTerms function also returns the default license terms and that the getAttachedLicenseTermsCount function includes the default license terms in its count. This enhancement will ensure that the default license terms are consistently considered in all relevant operations.

Objectives

  • Include Default License Terms in getAttachedLicenseTerms: Modify the getAttachedLicenseTerms function to return the default license terms along with any other attached license terms.
  • Count Default License Terms in getAttachedLicenseTermsCount: Update the getAttachedLicenseTermsCount function to include the default license terms in its count of attached license terms.

Acceptance Criteria

  • The getAttachedLicenseTerms function returns the default license terms along with any other attached license terms.
  • The getAttachedLicenseTermsCount function includes the default license terms in its count.
  • All tests pass, confirming the correct inclusion of default license terms in both functions.
  • Documentation is updated to reflect the new behavior of these functions.

This update is part of our ongoing efforts to improve the functionality and consistency of the LicenseRegistry contract.

@kingster-will kingster-will added the enhancement New feature or request label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant