Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up sdk version to 1.2.0-rc.2 #317

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Bump up sdk version to 1.2.0-rc.2 #317

merged 3 commits into from
Nov 13, 2024

Conversation

bonnie57
Copy link
Collaborator

Description

Features:

  • Feat/make isRegistered public
  • Add codeowners for pr review
  • Implement multicall feature

DonFungible and others added 3 commits November 11, 2024 00:53
@DonFungible
Feat/make isRegistered public (#311)
f6e0cd1 
* make isRegistered public

* make isRegistered public
@AndyBoWu
[feat] add codeowners for pr review (#316)
8113115
@bonnie57
Implement multicall (#314)
456fc3d 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
DonFungible
DonFungible approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@DonFungible DonFungible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DonFungible DonFungible merged commit b5a3b5c into main Nov 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonFungible DonFungible DonFungible approved these changes

@samfairbairn samfairbairn samfairbairn approved these changes

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@jacob-tucker jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bonnie57 @samfairbairn @DonFungible @AndyBoWu