Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing a string to the ready configuration block in prometheus exporter #5

Open
matthewdarwin opened this issue Jul 31, 2023 · 2 comments

Comments

@matthewdarwin
Copy link

We have different "firehose block versions" of an app running at the same time. I would be great if the ready status in the prometheus exporter could say which version was running.

Eg

# HELP ready readiness of an app. 1 if ready, 0 otherwise
# TYPE ready gauge
ready{app="firehose", block-version="v3"} 0

Where this might be configured as common-reporting-block-version: v3.

This is just for reporting, firehose doesn't do anything with it otherwise.

This was originally streamingfast/firehose-ethereum#68

@maoueh
Copy link
Contributor

maoueh commented Jul 31, 2023

Would you be fine with common-metrics-tags (not quite sure of the best name) so that you could provide a few user chosen tags so we could do --common-metrics-tags="block-version=v3,datacenter=d1".

What do you think?

@matthewdarwin
Copy link
Author

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants