Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix run.sh in kubernetes deploy tutorial #995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NikiforovG
Copy link

There was an inconsistent variable name.

📚 Context

🧠 Description of Changes

There was an inconsistent variable name. stopRunningProcess() was looking at APP_PID variable while APP_ID was defined at application run.

Revised:

streamlit run ${HOME}/app/streamlit_app.py &
APP_PID=${!}

wait ${APP_PID}

Current:

streamlit run ${HOME}/app/streamlit_app.py &
APP_ID=${!}

wait ${APP_ID}

💥 Impact

Small typo fix.

Size:

  • Small
  • Not small

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

There was inconsistent variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant