Add new chart test workflow #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsxu
reviewed
Sep 4, 2022
Yeah, chart-testing will need a version bump when the chart has new changes. I updated a new version in the testing to trigger the test, So I just revert the chart version after the tests are working. |
maxsxu
reviewed
Feb 24, 2023
maxsxu
reviewed
Feb 24, 2023
.github/workflows/chart_test.yml
Outdated
Comment on lines
25
to
30
| pull_request: | ||
| branches: | ||
| - '*' | ||
| paths: | ||
| - 'charts/**' | ||
| - '.github/workflows/**' |
There was a problem hiding this comment.
Should we restrict the paths to sn-platform?
FushuWang
force-pushed
the
fswang/add-chart-tests-for-sn-platform
branch
from
08164d8
to
a7ea904
Compare
FushuWang
force-pushed
the
fswang/add-chart-tests-for-sn-platform
branch
from
939b46d
to
abfaa5f
Compare
FushuWang
force-pushed
the
fswang/add-chart-tests-for-sn-platform
branch
from
612d743
to
4e32ea5
Compare
FushuWang
force-pushed
the
fswang/add-chart-tests-for-sn-platform
branch
3 times, most recently
from
c8c3a76
to
f9e055c
Compare
FushuWang
force-pushed
the
fswang/add-chart-tests-for-sn-platform
branch
from
8a7940c
to
8c67dc8
Compare
FushuWang
force-pushed
the
fswang/add-chart-tests-for-sn-platform
branch
4 times, most recently
from
bc398b3
to
8960167
Compare
FushuWang
force-pushed
the
fswang/add-chart-tests-for-sn-platform
branch
from
8e41d71
to
c440e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772
Motivation
Add new chart test workflow.
Modifications
Add new action
Verifying this change
Documentation
Check the box below.
Need to update docs?
no-need-doc(Please explain why)